Skip to content

DataTracks integration through FFI#66

Merged
stephen-derosa merged 33 commits intolivekit:mainfrom
stephen-derosa:sderosa/data_tracks
Apr 2, 2026
Merged

DataTracks integration through FFI#66
stephen-derosa merged 33 commits intolivekit:mainfrom
stephen-derosa:sderosa/data_tracks

Conversation

@stephen-derosa
Copy link
Copy Markdown
Contributor

@stephen-derosa stephen-derosa commented Feb 26, 2026 •
edited
Loading

Overview

Integrate DataTracks into the CPP SDK through the FFI

Details

  • setOnAudio/VideoFrameCallback() change signature to use track name
  • setOnAudio/VideoFrameCallback() addition signature to use track name
  • result.h file for floating up specific errors provided by the FFI
  • update token gen script to run for all tokens needed
  • Update client-sdk-rust submodule
  • data_track_subscription: on pushFrame() called when rust sends new frame, assert(since that breaks cpp<->ffi<->rust agreement of rust handling buffering

Testing

  • src/tests/integration/test_data_track.cpp

Examples

Blocked By

Rust SDKs PR

Resolves BOT-268

@stephen-derosa stephen-derosa self-assigned this Feb 26, 2026
@stephen-derosa stephen-derosa added the enhancement New feature or request label Feb 26, 2026
xianshijing-lk
xianshijing-lk reviewed Feb 26, 2026
View reviewed changes
ladvoc
ladvoc reviewed Feb 26, 2026
View reviewed changes
ladvoc
ladvoc reviewed Feb 26, 2026
View reviewed changes
ladvoc
ladvoc reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments, but I will make another pass. Looking clean so far!

ladvoc
ladvoc reviewed Feb 26, 2026
View reviewed changes
ladvoc
ladvoc reviewed Feb 26, 2026
View reviewed changes
ladvoc
ladvoc reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments.

@stephen-derosa stephen-derosa force-pushed the sderosa/data_tracks branch 3 times, most recently from 8647582 to 74e4b99 Compare March 6, 2026 00:49
@stephen-derosa stephen-derosa force-pushed the sderosa/data_tracks branch 2 times, most recently from 6413736 to 2b792db Compare March 19, 2026 22:15
@stephen-derosa stephen-derosa mentioned this pull request Mar 20, 2026
Closed
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
stephen-derosa
stephen-derosa commented Mar 20, 2026
View reviewed changes
@stephen-derosa
create*Track -> publish*Track()
9b2c49f
@stephen-derosa
dont add/remove stuff from bridge since we are targetting a branch wh…
53fe0ec 
…ich deprecates bridge. Add helper set/clearDataTrackCallback(), and publishDataTrack helper functions
@stephen-derosa
ActiveDataReader: subscriber mutex
bd6008b
@stephen-derosa
DataTrackSubscription: read() sends request for latest message
ccd91e8
@stephen-derosa
move realsense-livekit out of this
e413a18
@stephen-derosa
no changes to bridge
15b862c
@stephen-derosa
simple_status example
5a4fdf6
@stephen-derosa
multiple subscriptions
d82fa18
@stephen-derosa
hello_livekit example for a video track and data tracl
0194984
@stephen-derosa
move data track callback functionality to subscription_thread_dispatcher
52e00ff
@stephen-derosa
hello_livekit: sender.cpp/receiver.cpp
6b6abb8
@stephen-derosa
some data_tracks tests
71a9c07
@stephen-derosa
test_data_tracks.cpp
5d92bed
@stephen-derosa
setOnAudio/VideoFrameCallback() change signature to use track name
a03f192
@stephen-derosa
setOnAudio/VideoFrameCallback() addition signature to use track name
a9ff37c
@stephen-derosa
testing for new API
0974e57
@stephen-derosa
data_track_subscription: on pushFrame() called when rust sends new fr…
011b91a 
…ame, assert(since that breaks cpp<->ffi<->rust agreement of rust handling buffering
@stephen-derosa
DataTrack constructor operators for compiler efficiency. remove uneed…
4f2d80a 
…ed file
@stephen-derosa
DataFrame::fromOwnedInfo to align with video/audio_stream.cpp
bf9a1b6
@stephen-derosa
DataTrackSubscription: remove move constructor since it introduces ba…
ac90051 
…d callback semantics and the public API returns a shared_ptr<>. Clean up race logic in read() by making the subscription read req while locked. close(): reset subscription handle, listener_id_, and closed_ under lock. Then call RemoveListener() ouside lock
@stephen-derosa
result.h file for floating up specific errors provided by the FFI
ddab010
@stephen-derosa
BUG FIX: reset the frame after usage
b5aea7b
@stephen-derosa
lcaol_data_track: remove many overloaded tryPush() functions
61cbd0c
@stephen-derosa
subscribeDataTrackAsync -> subscribeDataTrack
907d60c 
update data tracks errors to latest proto errors

data_track_subscription -> data_track_stream

DataFrame -> DataTrackFrame
@stephen-derosa
update to new proto
f187f9e
@stephen-derosa
update token gen script to run for all tokens needed
5f912dd
@stephen-derosa stephen-derosa merged commit 905cca7 into livekit:main Apr 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1egoman 1egoman 1egoman left review comments

@ladvoc ladvoc ladvoc left review comments

@xianshijing-lk xianshijing-lk xianshijing-lk approved these changes

@chenosaurus chenosaurus Awaiting requested review from chenosaurus

Assignees

@stephen-derosa stephen-derosa

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephen-derosa @xianshijing-lk @1egoman @ladvoc